So my question is this, I have the leaderboard module set as "public" but the Dashboard (menu item) set as "registered"

I thought that would allow guests to see the leaderboard and if they click on a user they would be prompted to register/log in..

Instead, guests can see the Dashboard.  Is that the correct functionality?